Repository navigation
Add automatic rolling deployment & option to re-create admission webhook certs - #242
Merged
Merged
Conversation
duhminick
force-pushed
the
dominic-tls
branch
5 times, most recently
from
September 26, 2025 05:17
d749534 to
6d4b9f4
Compare
duhminick
force-pushed
the
dominic-tls
branch
from
September 26, 2025 05:42
6d4b9f4 to
b966065
Compare
sky333999
previously approved these changes
Oct 7, 2025
movence
reviewed
Oct 15, 2025
| @@ -0,0 +1,59 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
Maybe this is out of scope with this PR, but should we consider a way to organize minukube test scenarios? I can only imagine these cases will grow, so a folder structures will be nice
movence
approved these changes
Oct 20, 2025
sky333999
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: NA
Description of changes:
Certificate Management Enhancement:
recreateflag for auto-generated certificates in the admission webhooks configurationtrueto maintain backward compatibilityOperator Deployment Rolling:
rollingflag in the operator configuration to enable automatic deployment rollingfalseto preserve existing behaviorTesting
Recreate is enabled
With these values:
Recreate is disabled
With these values:
Rolling is enabled
With these values:
Rolling is disabled
With these values:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.