Repository navigation
Set up dcgmexporter interval to 1000ms when accelerated_compute_gpu_metrics_collection_interval is present and less than 60 - #248
Merged
sky333999 merged 1 commit intoNov 12, 2025
Conversation
yanhaoluo666
force-pushed
the
feature/gpu-metrics-high-sampling
branch
from
October 14, 2025 17:58
360d772 to
ee036c9
Compare
spanaik
reviewed
Oct 16, 2025
| {{- $intervalValue = $agentConfig.logs.metrics_collected.kubernetes.accelerated_compute_gpu_metrics_collection_interval -}} | ||
| {{- end -}} | ||
| {{- end -}} | ||
| {{- if and $intervalFound (lt $intervalValue 60) -}} |
Collaborator
There was a problem hiding this comment.
Lets await the results from internal testing, before we push this change to be 1 Sec, we want to ideally limit any impact to the underlying hardware.
Contributor
Author
There was a problem hiding this comment.
yes, will also connect with agent folks to get their thoughts.
yanhaoluo666
force-pushed
the
feature/gpu-metrics-high-sampling
branch
from
October 17, 2025 11:39
ee036c9 to
20d1be5
Compare
movence
previously approved these changes
Oct 17, 2025
…etrics_collection_interval is present and less than 60
yanhaoluo666
force-pushed
the
feature/gpu-metrics-high-sampling
branch
from
November 12, 2025 16:35
bf8f53d to
d3f132c
Compare
sky333999
approved these changes
Nov 12, 2025
movence
approved these changes
Nov 12, 2025
sky333999
pushed a commit
that referenced
this pull request
Nov 13, 2025
…etrics_collection_interval is present and less than 60 (#248)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Enabling high frequency GPU metrics requires customer to make changes in 2 places: one is cw agent config, the other is dcgmexporter config. It's a bit complicated and hard for add-on customers to make these changes.
Description of changes:
Write a help function to check the presence of
accelerated_compute_gpu_metrics_collection_interval, if it is present and value < 60, then addDCGM_EXPORTER_INTERVAL: 1000to dcgmexporter env.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing
DCGM_EXPORTER_INTERVAL: 1000was not in its env.accelerated_compute_gpu_metrics_collection_interval: 1tovalues.yamland deploy pod, checkedDCGM_EXPORTER_INTERVALwas in its env.