Repository navigation
Refactored logic for Fluentbit config parsing in isolated regions - #257
Merged
Merged
Conversation
sky333999
reviewed
Dec 11, 2025
sky333999
previously approved these changes
Dec 12, 2025
sky333999
approved these changes
Dec 12, 2025
movence
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change builds on top of #94. I was able to consolidate down the logic and added in THF. The changes should just be a logic change in generating them, but the generated artifact should not differ.
###Testing
I was able to confirm that we were able to apply the helm chart in 3 ADC regions aws-iso-b, aws-isof, and aws-iso as well as THF and GovCloud regions.