Repository navigation
[Cherry-pick FIPS 2025] Move dk to Tests in ML-KEM ACVP - #2869
Merged
samuel40791765 merged 1 commit intoNov 28, 2025
Merged
samuel40791765 merged 1 commit into
samuel40791765 merged 1 commit into
Conversation
### Description of changes: NIST moved the private key in the ML-KEM decapsulation tests from the group to the individual tests. Upstream BoringSSL has a similar change here: google/boringssl@f12962c. ### Call-outs: This will be cherry-picked over to FIPS branch once in main. ### Testing: Updated ACVP tests By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 1570066)
WillChilds-Klein
approved these changes
Nov 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fips-2025-09-12 #2869 +/- ##
================================================
Coverage 78.70% 78.71%
================================================
Files 667 667
Lines 113002 113003 +1
Branches 16062 16062
================================================
+ Hits 88942 88948 +6
+ Misses 23286 23280 -6
- Partials 774 775 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nebeid
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry picked from commit on main: 1570066
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.