Repository navigation
[Cherry-pick FIPS 2025] Add encap/decapKeyCheck support in ACVP - #2875
Merged
samuel40791765 merged 1 commit intoDec 2, 2025
Merged
Conversation
ACVP has support for a new test vectors that test against the encapsulation/decapsulation key checks defined in FIPS 203. > Adds "encapsulationKeyCheck" and "decapsulationKeyCheck" as functions for ML-KEM Encap/Decap FIPS203 to exercise an implementation's capability to perform the Encapsulation Key Check in FIPS 203 Section 7.2 and the Decapsulation Key Check in FIPS 203 Section 7.3. These tests are only included if the appropriate function is present in the registration. They operate by providing a valid or invalid key and expecting the IUT to return a true for a valid key or false for an invalid key. * https://github.com/usnistgov/ACVP-Server/releases This add support in ACVP to run against the relevant `crypto_kem_check_pk` and `crypto_kem_check_sk` functions that do the checks for us. Also added the new `encapsulationKeyCheck` and `decapsulationKeyCheck` test vectors in `ML-KEM.bz2`. ### Call-outs: N/A ### Testing: new `encapsulationKeyCheck` and `decapsulationKeyCheck` test vectors in `ML-KEM.bz2` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 0336dd7)
skmcgrail
approved these changes
Dec 2, 2025
samuel40791765
enabled auto-merge (squash)
December 2, 2025 21:04
dkostic
approved these changes
Dec 2, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fips-2025-09-12 #2875 +/- ##
===================================================
- Coverage 78.71% 78.68% -0.03%
===================================================
Files 667 667
Lines 113002 113027 +25
Branches 16062 16068 +6
===================================================
- Hits 88946 88933 -13
- Misses 23281 23317 +36
- Partials 775 777 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry picked from commit on main: 0336dd7
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.