Skip to content

Update NID_rsaesOaep test certificate - #3194

Merged
crlorentzen merged 2 commits into
aws:mainfrom
crlorentzen:main
Apr 28, 2026
Merged

crlorentzen merged 2 commits into
aws:mainfrom
crlorentzen:main

Conversation

@crlorentzen

@crlorentzen crlorentzen commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes:

The NID_rsaesOaep test certificate in crypto/x509/x509_test.cc has been replaced with an updated certificate that uses SHA-256 for its signature algorithm instead of SHA-1. The new certificate preserves the same rsaesOaep SubjectPublicKeyInfo structure required by the test while using a more current signing algorithm.

Call-outs:

This is a test-data-only change — no functional code is modified. The replacement certificate maintains the same issuer DN, OAEP SPKI algorithm, and validity period so existing test assertions continue to pass. A corresponding certificate update was also made to the parallel OpenSSL PR openssl/openssl#30961

Testing:

The existing X509Test.ITUT_X509_nid_rsaesOaep test exercises the replacement certificate. No new tests are needed since the change is limited to swapping the test data.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.98%. Comparing base (7364c96) to head (844080a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3194      +/-   ##
==========================================
- Coverage   77.99%   77.98%   -0.01%     
==========================================
  Files         689      689              
  Lines      122654   122654              
  Branches    17073    17072       -1     
==========================================
- Hits        95667    95655      -12     
- Misses      26088    26101      +13     
+ Partials      899      898       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@crlorentzen
crlorentzen merged commit f7e3ac7 into aws:main Apr 28, 2026
482 of 485 checks passed
justsmth pushed a commit that referenced this pull request May 13, 2026
…arse_key_type (#3246)

### Issues:
n/a

### Description of changes: 
Cherry-pick #3181 and #3194 

### Testing:
* CI

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.

This branch was previously deployed

1 inactive deployment
auto-approve — a489dde7 Deployed Apr 28, 2026 by justsmth via android-debug-static #890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants