Repository navigation
Update NID_rsaesOaep test certificate - #3194
Merged
Merged
Conversation
crlorentzen
temporarily deployed
to
auto-approve
April 27, 2026 15:11 — with
GitHub Actions
Inactive
crlorentzen
temporarily deployed
to
auto-approve
April 27, 2026 15:11 — with
GitHub Actions
Inactive
crlorentzen
temporarily deployed
to
auto-approve
April 27, 2026 15:11 — with
GitHub Actions
Inactive
crlorentzen
temporarily deployed
to
auto-approve
April 27, 2026 15:11 — with
GitHub Actions
Inactive
crlorentzen
temporarily deployed
to
auto-approve
April 27, 2026 15:11 — with
GitHub Actions
Inactive
crlorentzen
temporarily deployed
to
auto-approve
April 27, 2026 15:11 — with
GitHub Actions
Inactive
justsmth
approved these changes
Apr 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3194 +/- ##
==========================================
- Coverage 77.99% 77.98% -0.01%
==========================================
Files 689 689
Lines 122654 122654
Branches 17073 17072 -1
==========================================
- Hits 95667 95655 -12
- Misses 26088 26101 +13
+ Partials 899 898 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillChilds-Klein
approved these changes
Apr 27, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The NID_rsaesOaep test certificate in crypto/x509/x509_test.cc has been replaced with an updated certificate that uses SHA-256 for its signature algorithm instead of SHA-1. The new certificate preserves the same rsaesOaep SubjectPublicKeyInfo structure required by the test while using a more current signing algorithm.
Call-outs:
This is a test-data-only change — no functional code is modified. The replacement certificate maintains the same issuer DN, OAEP SPKI algorithm, and validity period so existing test assertions continue to pass. A corresponding certificate update was also made to the parallel OpenSSL PR openssl/openssl#30961
Testing:
The existing X509Test.ITUT_X509_nid_rsaesOaep test exercises the replacement certificate. No new tests are needed since the change is limited to swapping the test data.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.