Skip to content

feat: make sam sync use express mode by default - #9284

Merged
reedham-aws merged 2 commits into
aws:developfrom
reedham-aws:sync-express-default
Sep 24, 2026
Merged

reedham-aws merged 2 commits into
aws:developfrom
reedham-aws:sync-express-default

Conversation

@reedham-aws

Copy link
Copy Markdown
Contributor

Why is this change necessary?

We have previously stated in #9110 that we will make sam sync use CloudFormation express mode by default after 9/23. This change enables that.

What side effects does this change have?

This is changing the default behavior of the sam sync command.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reedham-aws
reedham-aws requested a review from a team as a code owner September 22, 2026 18:24
@github-actions github-actions Bot added area/sync sam sync command area/schema JSON schema file pr/internal labels Sep 22, 2026

@aws-sam-tooling-bot aws-sam-tooling-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: 5b20d0e..ec1048d
Files: 2
Comments: 1

Comment thread samcli/commands/sync/command.py Resolved

@aws-sam-tooling-bot aws-sam-tooling-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Results

Reviewed: 5b20d0e..dafec50
Files: 3
Comments: 2

Comment thread samcli/commands/sync/command.py Resolved
Comment thread samcli/commands/sync/command.py Resolved
@reedham-aws

Copy link
Copy Markdown
Contributor Author

I'm not concerned about either of the AI comments, we hadn't been testing the default before and aren't now either. We tests both the --express and --no-express cases in the integ tests, and it doesn't seem like we usually test the click param defaults.

@roger-zhangg roger-zhangg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@reedham-aws
reedham-aws merged commit 559a64a into aws:develop Sep 24, 2026
99 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/schema JSON schema file area/sync sam sync command pr/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants