Repository navigation
ci: wait for the build images of a release before running its integration tests - #9342
Merged
Merged
Conversation
vicheey
approved these changes
Oct 15, 2026
reedham-aws
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
aws/aws-sam-build-images#208
Why is this change necessary?
Build images for a release are published at the same time the release integration tests start, so container build tests run against the previous release's images. A broken build image (aws/aws-sam-build-images#208) passed the release tests this way.
How does it address the issue?
Adds a
wait-for-build-imagesjob that all integration test jobs depend on. For latest-release runs,tests/wait_for_build_images.pypolls Public ECR every minute until each build image published for the previous release has a<version>-<arch>tag thatlatest-<arch>points to. It uses the existing Public ECR login password, which is nowget_ecr_public_password()intests/setup_testing_resources.py.Test runs:
install_mode=latest-release(waits): https://github.com/aws/aws-sam-cli/actions/runs/38653352841install_mode=nightly-release(wait job skipped): https://github.com/aws/aws-sam-cli/actions/runs/38653399676What side effects does this change have?
Release integration tests start after the build images are published, or fail after 120 minutes if they aren't. Other triggers skip the wait job.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.