Skip to content

updating python3.10 to python3.14 for tests - #9391

Merged
Vandita2020 merged 1 commit into
aws:developfrom
Vandita2020:update-python310-tests-to-314
Nov 2, 2026
Merged

Vandita2020 merged 1 commit into
aws:developfrom
Vandita2020:update-python310-tests-to-314

Conversation

@Vandita2020

Copy link
Copy Markdown
Contributor

Which issue(s) does this change fix?

Why is this change necessary?

How does it address the issue?

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Vandita2020
Vandita2020 requested a review from a team as a code owner November 2, 2026 17:34

@aws-sam-tooling-bot aws-sam-tooling-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Lambda Tooling PR Reviewer: No high-confidence issues found.

1 lower-confidence observation: these passed verification at a lower score, so check before acting

1. [BUG] tests/integration/buildcmd/build_integ_base.py:849: Makefile build tests now run the pinned requests==2.23.0 on python3.14, where it may fail to import

BuildIntegProvidedBase._test_with_Makefile invokes the built function using _get_python_version() as the runtime and expects "2.23.0" back. The fixture Provided/requirements.txt pins requests==2.23.0, which allows only urllib3<1.26. That urllib3 bundles an old copy of six whose import hook doesn't work on Python 3.12 and later, so import requests should raise ModuleNotFoundError: urllib3.packages.six.moves. To check, run one of the TestBuildCommand_ProvidedFunctions tests with Docker enabled. If it fails, bump the pin in requirements.txt and the expected version string to match.

@Vandita2020
Vandita2020 merged commit 8fdc2b2 into aws:develop Nov 2, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants