Repository navigation
test: specify only major.minor version of Ruby - #9410
Merged
Merged
Conversation
All tests work fine with whatever minor version of ruby exists, so there's no need to specify `3.4.7`, since `3.4` should work just fine. This prevents us having to update the version to the latest one every once in a while. For the `sync` test, the "before" ruby version was set as 3.2, but the Lambda function was actually configured as 3.4 already, so I also updated that to 3.4, since the "before/after" change is not related to the version.
reedham-aws
approved these changes
Nov 7, 2026
Contributor
Author
|
Integ tests: https://github.com/aws/aws-sam-cli/actions/runs/42311009784/job/128252083694 |
seshubaws
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests work fine with whatever minor version of ruby exists, so there's no need to specify
3.4.7, since3.4should work just fine. This prevents us having to update the version to the latest one every once in a while.For the
synctest, the "before" ruby version was set as 3.2, but the Lambda function was actually configured as 3.4 already, so I also updated that to 3.4, since the "before/after" change is not related to the version.Which issue(s) does this change fix?
Why is this change necessary?
How does it address the issue?
3.2.7) and just keep major.minor a.k.a.3.2,3.3and3.4What side effects does this change have?
We don't know exactly the Ruby version being used, since it will just whatever chooses by default.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.