Skip to content

test: specify only major.minor version of Ruby - #9410

Merged
seshubaws merged 1 commit into
developfrom
test/change-ruby-versions
Nov 7, 2026
Merged

seshubaws merged 1 commit into
developfrom
test/change-ruby-versions

Conversation

@valerena

@valerena valerena commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

All tests work fine with whatever minor version of ruby exists, so there's no need to specify 3.4.7, since 3.4 should work just fine. This prevents us having to update the version to the latest one every once in a while.

For the sync test, the "before" ruby version was set as 3.2, but the Lambda function was actually configured as 3.4 already, so I also updated that to 3.4, since the "before/after" change is not related to the version.

Which issue(s) does this change fix?

Why is this change necessary?

  • A recent update in GitHub Runners broke all tests because we had an old version of Ruby pinned.

How does it address the issue?

  • Stop pinning the patch version (like 3.2.7) and just keep major.minor a.k.a. 3.2, 3.3 and 3.4

What side effects does this change have?

We don't know exactly the Ruby version being used, since it will just whatever chooses by default.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

All tests work fine with whatever minor version of ruby exists, so
there's no need to specify `3.4.7`, since `3.4` should work just fine.
This prevents us having to update the version to the latest one every
once in a while.

For the `sync` test, the "before" ruby version was set as 3.2, but the
Lambda function was actually configured as 3.4 already, so I also
updated that to 3.4, since the "before/after" change is not related to
the version.
@valerena
valerena requested a review from a team as a code owner November 6, 2026 23:18
@valerena

valerena commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Integ tests: https://github.com/aws/aws-sam-cli/actions/runs/42311009784/job/128252083694
There's one unrelated test failure in a MicroVM test.

@seshubaws
seshubaws merged commit 3bc9bcd into develop Nov 7, 2026
105 of 108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants