Skip to content

Netty HTTP Proxy Support #858

Closed
Closed

Description

@millems

The Apache HTTP implementation supports proxy configuration, but Netty does not. This feature should be added to Netty.

Activity

  1. self-assigned this
    on Nov 30, 2018
  2. favetelinguis commented on Jan 16, 2019

    @favetelinguis

    Any status updates on this?

  3. vinayys commented on Mar 4, 2019

    @vinayys

    @dagnir - any update on this?

  4. dagnir commented on Mar 4, 2019

    @dagnir
    Contributor

    Hi @favetelinguis @vinayys we still have this planned, but have not begun work on this yet.

  5. alexmnyc commented on Mar 7, 2019

    @alexmnyc

    this is very much needed for anyone working in enterprise,.,.,,,,

  6. IDWalsh commented on Mar 8, 2019

    @IDWalsh

    This is a major issue for us adopting it.

  7. danieladams456 commented on May 22, 2019

    @danieladams456

    We want to use Spring Boot Webflux to build reactive services. Currently will have to wrap SDK calls in their own separate thread pools rather than just using Netty all the way through.

    Spring Boot lets you inject a Reactor Netty HttpClient, but I assume you all are using Netty directly instead of Reactor Netty so that wouldn't be available.

  8. changed the title [-]Support HTTP proxies with Netty[/-] [+]Netty HTTP Proxy Support[/+] on Jul 8, 2019
  9. Krishnaghimire commented on Aug 15, 2019

    @Krishnaghimire

    +1

  10. BhargavChoksi commented on Oct 14, 2019

    @BhargavChoksi

    Can we please add the proxy config support for DynamoDbAsyncClient ?????

    I am in urgent need.

  11. dagnir commented on Oct 16, 2019

    @dagnir
    Contributor

    Hi @BhargavChoksi, this feature was built into the Netty HTTP client instead of at the service clients level. To use the Netty client's proxying feature with the DynamoDB client, you will need to configure the Netty client directly on the client:

            SdkAsyncHttpClient.Builder nettyBuilder = NettyNioAsyncHttpClient.builder()
                    .proxyConfiguration(ProxyConfiguration.builder()
                            ...
                            .build());
    
            DynamoDbAsyncClient ddb = DynamoDbAsyncClient.builder()
                    .httpClientBuilder(nettyBuilder)
                    .build();
  12. BhargavChoksi commented on Oct 16, 2019

    @BhargavChoksi

    Thanks a lot @dagnir, for your quick response. Here, I am able to set proxy-host and proxy-port.
    How can I set proxy username and proxy-password?

    It seems there is no way to set proxy-username ans proxy-password or I am horribly missing something?

    final ProxyConfiguration proxyConfiguration =
    ProxyConfiguration.builder().host("http-se.some.host.com").port(8080).build();

  13. dagnir commented on Oct 16, 2019

    @dagnir
    Contributor

    Hey @BhargavChoksi That is not currently supported at the moment. This is being tracked here: #1432

  14. dagnir commented on Oct 17, 2019

    @dagnir
    Contributor

    Marking this is done. Other proxy related features will be tracked separately (e.g. #1432)

  15. LindaByrne commented on Oct 18, 2019

    @LindaByrne

    Thanks for implementing this, it's working well for me.

    One note though, the example configuration here shows using the KinesisClientUtil.createKinesisAsyncClient method which will override setting httpClientBuilder on the KinesisAsyncClientBuilder. Using the KinesisAsyncClient.builder() directly solves this issue.

  16. added a commit that references this issue on May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

feature-requestA feature should be added or improved.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions