Skip to content
This repository was archived by the owner on Jun 22, 2026. It is now read-only.

fix: check for ubuntu based distro to install ssm plugin - #5571

Merged
mergify[bot] merged 6 commits into
aws:mainlinefrom
KollaAdithya:ubuntu/fix/ssm
Dec 19, 2023
Merged

mergify[bot] merged 6 commits into
aws:mainlinefrom
KollaAdithya:ubuntu/fix/ssm

Conversation

@KollaAdithya

Copy link
Copy Markdown
Contributor

related #2561

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@KollaAdithya
KollaAdithya requested a review from a team as a code owner December 18, 2023 17:15
@KollaAdithya
KollaAdithya requested review from huanjani and removed request for a team December 18, 2023 17:15
@github-actions

github-actions Bot commented Dec 18, 2023 •

Copy link
Copy Markdown

πŸ• Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 56932 56796 +0.24
macOS (arm) 57964 57796 +0.29
linux (amd) 49924 49804 +0.24
linux (arm) 49152 49092 +0.12
windows (amd) 47048 46940 +0.23

@KollaAdithya KollaAdithya changed the title fix: change logic for checking ubuntu based distro fix: check for ubuntu based distro to install ssm plugin Dec 18, 2023
@codecov-commenter

codecov-commenter commented Dec 18, 2023 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
βœ… Project coverage is 70.01%. Comparing base (9bc5f46) to head (e9a960d).
⚠️ Report is 150 commits behind head on mainline.

Files with missing lines Patch % Lines
...pkg/exec/ssm_plugin_install_latest_binary_linux.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           mainline    #5571   +/-   ##
=========================================
  Coverage     70.00%   70.01%           
=========================================
  Files           302      302           
  Lines         46403    46417   +14     
  Branches        301      301           
=========================================
+ Hits          32486    32499   +13     
  Misses        12338    12338           
- Partials       1579     1580    +1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iamhopaul123 iamhopaul123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: nit: we can deploy a service with an ubuntu based image and then exec into the container to verify.

@KollaAdithya

Copy link
Copy Markdown
Contributor Author

I tested this on PopOS installed on my virtual machine.

@mergify
mergify Bot merged commit 66d1943 into aws:mainline Dec 19, 2023
@KollaAdithya
KollaAdithya deleted the ubuntu/fix/ssm branch January 19, 2024 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants