Repository navigation
Revert to use Set for metricsEnabledDimension - #1715
Merged
lucienlu-aws merged 1 commit intoMar 10, 2026
Merged
Conversation
lucienlu-aws
temporarily deployed
to
manual-approval
March 9, 2026 23:45 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
vincentvilo-aws
approved these changes
Mar 10, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
#1258 changed the type of the MetricsConfig metricsEnabledDimension to be a Hashset from a Set to address #692. However, in KCL v3, a better fix was put in which allows the multilang config parser to check parent types https://github.com/awslabs/amazon-kinesis-client/blob/v3.0.0/amazon-kinesis-client-multilang/src/main/java/software/amazon/kinesis/multilang/config/ConfigurationSettableUtils.java#L96-L109.
This commit makes the type a Set again to allow for simpler setting of this config. This should not break any existing functionality for users who set already set this with a
HashSetasSetis a parentBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.