Repository navigation
Ensure heartbeat is stopped for graceful handoff lease in shutting do… - #1729
Merged
Merged
Conversation
chenylee-aws
had a problem deploying
to
manual-approval
April 9, 2026 18:48 — with 
GitHub Actions
Failure
GitHub Actions
Failure
lucienlu-aws
reviewed
Apr 9, 2026
chenylee-aws
force-pushed
the
leaseshutdown
branch
from
April 10, 2026 00:50
97b3468 to
f363482
Compare
chenylee-aws
had a problem deploying
to
manual-approval
April 10, 2026 00:50 — with
GitHub Actions
Failure
GitHub Actions
Failure
lucienlu-aws
approved these changes
Apr 10, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix graceful lease handoff when a ShardConsumer receives a graceful handoff request before reaching the initialized state. Due to lifecycle management, the ShardConsumer transitions directly from WAITING_ON_PARENT_SHARDS to shutdown, skipping ShutdownNotificationTask, leaving the lease never transferred or dropped.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.