Repository navigation
Add StreamType to StreamIdentifier and skip hash range ERROR logs for⦠- #1730
Merged
ehasah-aws merged 1 commit intoApr 21, 2026
Merged
Conversation
rahultg1411
had a problem deploying
to
manual-approval
April 13, 2026 13:16 — with
GitHub Actions
Failure
β¦ DynamoDB Streams (awslabs#1709)
rahultg1411
force-pushed
the
fix/hash-range-stream-type
branch
from
April 13, 2026 17:38
1ed60fe to
6b28335
Compare
rahultg1411
temporarily deployed
to
manual-approval
April 13, 2026 17:38 — with
GitHub Actions
Inactive
rahultg1411
marked this pull request as ready for review
April 15, 2026 02:27
gguptp
approved these changes
Apr 15, 2026
ehasah-aws
approved these changes
Apr 21, 2026
rahultg1411
added a commit
to rahultg1411/dynamodb-streams-kinesis-adapter
that referenced
this pull request
May 4, 2026
Pass DynamoDB_Streams stream type in both single and multi stream tracker creation so KCL can identify DynamoDB Streams and skip hash range ERROR logs. Depends on: awslabs/amazon-kinesis-client#1730 Resolves: awslabs#74
rahultg1411
added a commit
to rahultg1411/dynamodb-streams-kinesis-adapter
that referenced
this pull request
May 4, 2026
Pass DynamoDB_Streams stream type in both single and multi stream tracker creation so KCL can identify DynamoDB Streams and skip hash range ERROR logs. Depends on: awslabs/amazon-kinesis-client#1730 Resolves: awslabs#74
rattang-dev
pushed a commit
to awslabs/dynamodb-streams-kinesis-adapter
that referenced
this pull request
May 4, 2026
Pass DynamoDB_Streams stream type in both single and multi stream tracker creation so KCL can identify DynamoDB Streams and skip hash range ERROR logs. Depends on: awslabs/amazon-kinesis-client#1730 Resolves: #74
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes backward compatibility issue introduced in #1709 (reverted by KCL team due to compat check failure).
Description of changes:
Adds streamType field to StreamIdentifier to distinguish DynamoDB Streams from Kinesis Data Streams, allowing PeriodicShardSyncManager to skip hash range validation ERROR logs for non-Kinesis streams.
To fix the backward compatibility issue (adding a field changes Lombok's auto-generated constructor signature), moved @builder(toBuilder = true) from the class to an explicit private constructor and added a package-private 4-arg constructor matching the old signature. A partial StreamIdentifierBuilder class provides field defaults (replacing @Builder.Default). Builder remains public for Pod1 ARN support.
Files changed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.