Repository navigation
Scheduler.run: properly close metricsScope - #1734
Merged
Merged
Conversation
john-karp
had a problem deploying
to
manual-approval
April 28, 2026 19:04 — with 
GitHub Actions
Failure
GitHub Actions
Failure
chenylee-aws
approved these changes
May 1, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduler.run()is creating aMetricsScope, but it never callsend()on it, either directly or withMetricsUtil.endScope. This means that the metrics fromScheduler.run()are never published.This issue has been present since KCL v3.0.0: fbfd74d / https://github.com/awslabs/amazon-kinesis-client/blame/fbfd74df39bf1714a2faee21d21bbff5b885f095/amazon-kinesis-client/src/main/java/software/amazon/kinesis/coordinator/Scheduler.java#L442-L455
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.