Repository navigation
Treat expired pending handoff leases as available lease to take - #1765
Merged
Merged
Conversation
chenylee-aws
had a problem deploying
to
manual-approval
May 29, 2026 04:35 — with
GitHub Actions
Failure
chenylee-aws
force-pushed
the
lease_count_shutdown
branch
from
May 29, 2026 04:37
f50b94e to
ad20531
Compare
chenylee-aws
had a problem deploying
to
manual-approval
May 29, 2026 04:38 — with
GitHub Actions
Failure
lucienlu-aws
approved these changes
Jun 2, 2026
vincentvilo-aws
pushed a commit
to vincentvilo-aws/amazon-kinesis-client
that referenced
this pull request
Jun 17, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
LeaseCountBasedLeaseAssignmentDecider.balanceWorkerVariance()previously excluded all leases withshutdownRequested=truefrom rebalancing, even after the handoff timed out. This PR replaces theshutdownRequested()filter withblockedOnPendingCheckpoint(currentTimeMillis), so expired handoff leases can be reassigned while active handoffs remain protected.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.