Repository navigation
Addressed memory leaks and improved overall memory usage - #1799
Merged
Merged
Conversation
pelaezryan
commented
Jul 28, 2026
pelaezryan
commented
Contributor
- Fixed a memory leak in PeriodicShardSyncManager where hashRangeHoleTrackerMap retained entries for deleted streams by adding cleanup via retainAll after each sync run.
- Reduced memory overhead in LeaseAssignmentManager by replacing full Lease object storage in prevRunLeasesState with a lightweight LeaseCounterSnapshot that only retains the fields actually needed
- streamToShardSyncTaskManagerMap in the Scheduler is a class level map that is always added to but never cleaned up. The only time this map was getting "flushed" was during a deployment where the leader is bounced. This change introduces cleanup logic to that map.
pelaezryan
had a problem deploying
to
manual-approval
July 28, 2026 17:19 — with 
GitHub Actions
Failure
GitHub Actions
Failure
pelaezryan
changed the title
akidambisrinivasan
approved these changes
Jul 28, 2026
| scope.end(); | ||
| } | ||
| } else { | ||
| log.debug("WorkerId {} is not a leader, not running the shard sync task", workerId); |
Contributor
There was a problem hiding this comment.
Actually as a good practice we should clean up any state on leader when the leader changes
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
