Repository navigation
Table Migration metrics fixes - #1811
Merged
Merged
Conversation
Fix the flaky rollback detection from phase2 to phase1. This is because anytime leader changes, it doesnt have the latest LAM state yet until LAM runs again, therefore it ends up using stale data to determine the phase2 vs phase1 worker and triggers a rollback. Put in 2 fixes for this: 1. Reset state (LAM state) when leadership is lost and dont perform rollback check without latest LAM state 2. Monitor consistent rollback signals and not a one off, worker restart triggering the rollback. So a rollback signal must exist consecutively 20 iterations before rollback will be performed
chenylee-aws
approved these changes
Sep 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the flaky rollback detection from phase2 to phase1. This is because anytime leader changes, it doesnt have the latest LAM state yet until LAM runs again, therefore it ends up using stale data to determine the phase2 vs phase1 worker and triggers a rollback.
Put in 2 fixes for this:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.