Repository navigation
Add fixed-width threshold option for variance-based lease rebalancing - #1814
Merged
ehasah-aws merged 10 commits intoSep 24, 2026
Merged
Conversation
ehasah-aws
had a problem deploying
to
manual-approval
September 17, 2026 00:29 — with 
GitHub Actions
Failure
GitHub Actions
Failure
ehasah-aws
had a problem deploying
to
manual-approval
September 22, 2026 03:10 — with
GitHub Actions
Failure
GitHub Actions
Failure
ehasah-aws
requested a deployment
to
manual-approval
September 22, 2026 16:08 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
ehasah-aws
changed the title
ehasah-aws
marked this pull request as ready for review
September 22, 2026 20:54
| private boolean allowThroughputOvershoot = true; | ||
|
|
||
| /** | ||
| * When set to true, the reBalanceThresholdPercentage is applied as fixed percentage points. |
Contributor
There was a problem hiding this comment.
nit: use {@link #reBalanceThresholdPercentage}?
| WorkerMetricStats mostLoadedWorker = null; | ||
|
|
||
| log.info("Range for re-balance upper threshold {} and lower threshold {}", upperLimit, lowerLimit); | ||
| log.info("Range for re-balance upper threshold {} and lower threshold {}", upperLimit, Math.max(0, lowerLimit)); |
Contributor
There was a problem hiding this comment.
Can we clamp down lower and upper to be within 0-100 ?
| /** | ||
| * When set to true, the reBalanceThresholdPercentage is applied as fixed percentage points. | ||
| * The rebalancing range is calculated as | ||
| * [fleetAvgCPU - reBalanceThresholdPercentage/2, fleetAvgCPU + reBalanceThresholdPercentage/2]. |
Contributor
There was a problem hiding this comment.
avoid using cpu sicne this is across all metrics? Maybe use fleetAvgMetricValue ?
ehasah-aws
had a problem deploying
to
manual-approval
September 23, 2026 00:43 — with
GitHub Actions
Failure
GitHub Actions
Failure
ehasah-aws
force-pushed
the
low-throughput-rebalancing
branch
from
September 23, 2026 00:53
bd9ec91 to
d0e500d
Compare
ehasah-aws
had a problem deploying
to
manual-approval
September 23, 2026 00:53 — with
GitHub Actions
Failure
GitHub Actions
Failure
ehasah-aws
force-pushed
the
low-throughput-rebalancing
branch
from
September 23, 2026 01:08
d0e500d to
b83c4ca
Compare
ehasah-aws
had a problem deploying
to
manual-approval
September 23, 2026 01:08 — with
GitHub Actions
Failure
GitHub Actions
Failure
ehasah-aws
had a problem deploying
to
manual-approval
September 23, 2026 18:14 — with
GitHub Actions
Failure
GitHub Actions
Failure
| upperLimit = Math.min(100, workerMetricsValueAvg + halfBand); | ||
| lowerLimit = Math.max(0, workerMetricsValueAvg - halfBand); | ||
| } else { | ||
| upperLimit = workerMetricsValueAvg * (1.0D + (double) reBalanceThreshold / 100); |
Contributor
There was a problem hiding this comment.
lets apply the clamping here too?
akidambisrinivasan
previously approved these changes
Sep 23, 2026
ehasah-aws
had a problem deploying
to
manual-approval
September 24, 2026 02:12 — with
GitHub Actions
Failure
GitHub Actions
Failure
akidambisrinivasan
approved these changes
Sep 24, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
useAbsoluteReBalanceThreshold(default false) is added.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.