Repository navigation
Emit RecordsFailedProcessing when the record processor throws - #1838
Merged
chenylee-aws merged 2 commits intoOct 30, 2026
Merged
chenylee-aws merged 2 commits into
chenylee-aws merged 2 commits into
Conversation
chenylee-aws
force-pushed
the
3.x-processrecords-failure-metrics
branch
2 times, most recently
from
October 29, 2026 18:32
4025d50 to
0d6c54e
Compare
chenylee-aws
requested a deployment
to
manual-approval
October 29, 2026 19:48 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
chenylee-aws
marked this pull request as ready for review
October 29, 2026 20:38
lucienlu-aws
previously approved these changes
Oct 29, 2026
vincentvilo-aws
previously approved these changes
Oct 29, 2026
chenylee-aws
dismissed stale reviews from vincentvilo-aws and lucienlu-aws
via
October 29, 2026 22:00
8dc4be0
chenylee-aws
force-pushed
the
3.x-processrecords-failure-metrics
branch
from
October 29, 2026 22:00
0d6c54e to
8dc4be0
Compare
vincentvilo-aws
previously approved these changes
Oct 29, 2026
chenylee-aws
requested a deployment
to
manual-approval
October 29, 2026 22:58 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
chenylee-aws
force-pushed
the
3.x-processrecords-failure-metrics
branch
from
October 29, 2026 23:36
8dc4be0 to
f42434b
Compare
chenylee-aws
changed the title
chenylee-aws
force-pushed
the
3.x-processrecords-failure-metrics
branch
2 times, most recently
from
October 29, 2026 23:41
cd93c9b to
02c10dd
Compare
chenylee-aws
requested a deployment
to
manual-approval
October 29, 2026 23:46 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
chenylee-aws
requested a deployment
to
manual-approval
October 29, 2026 23:48 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
chenylee-aws
requested a deployment
to
manual-approval
October 29, 2026 23:57 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
When processRecords() throws, emit RecordsFailedProcessing with the number of records in the batch at shard and application level. KCL does not retry at this point, so it is an upper bound on records impacted by record processor failures.
RecordsProcessed was emitted before the handoff, so records in a batch where processRecords() threw were also counted as processed. Emit it after processRecords() returns. It now counts records delivered to the record processor (after checkpoint filtering), and failed batches are counted only in RecordsFailedProcessing.
chenylee-aws
force-pushed
the
3.x-processrecords-failure-metrics
branch
from
October 29, 2026 23:59
1609f19 to
3ea5933
Compare
chenylee-aws
requested a deployment
to
manual-approval
October 30, 2026 00:06 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
lucienlu-aws
approved these changes
Oct 30, 2026
vincentvilo-aws
pushed a commit
to vincentvilo-aws/amazon-kinesis-client
that referenced
this pull request
Nov 3, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.