Repository navigation
[v2.x] Emit RecordsFailedProcessing when the record processor throws - #1839
Merged
chenylee-aws merged 2 commits intoOct 30, 2026
Merged
Conversation
chenylee-aws
force-pushed
the
v2.x-records-skipped-metric
branch
2 times, most recently
from
October 29, 2026 18:32
d2bcfeb to
809a219
Compare
chenylee-aws
marked this pull request as ready for review
October 29, 2026 20:38
lucienlu-aws
previously approved these changes
Oct 29, 2026
chenylee-aws
force-pushed
the
v2.x-records-skipped-metric
branch
from
October 29, 2026 22:00
809a219 to
2ee502e
Compare
vincentvilo-aws
previously approved these changes
Oct 29, 2026
chenylee-aws
force-pushed
the
v2.x-records-skipped-metric
branch
from
October 29, 2026 23:37
2ee502e to
ee05c14
Compare
chenylee-aws
changed the title
chenylee-aws
force-pushed
the
v2.x-records-skipped-metric
branch
2 times, most recently
from
October 29, 2026 23:41
dbd5eca to
7c3010a
Compare
When processRecords() throws, emit RecordsFailedProcessing with the number of records in the batch at shard and application level. KCL does not retry at this point, so it is an upper bound on records impacted by record processor failures.
RecordsProcessed was emitted before the handoff, so records in a batch where processRecords() threw were also counted as processed. Emit it after processRecords() returns. It now counts records delivered to the record processor (after checkpoint filtering), and failed batches are counted only in RecordsFailedProcessing.
chenylee-aws
force-pushed
the
v2.x-records-skipped-metric
branch
from
October 29, 2026 23:59
080f0a2 to
dc095ae
Compare
lucienlu-aws
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.