Repository navigation
Bound DynamoDB lock client calls with dynamoDbRequestTimeout - #1842
Merged
chenylee-aws merged 1 commit intoOct 30, 2026
Merged
Conversation
chenylee-aws
requested a deployment
to
manual-approval
October 30, 2026 01:40 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
DynamoDbAsyncToSyncClientAdapter waited on each call with an untimed join(), so a call that never completes could block isLeader() and every caller behind it forever. Wait with FutureUtils.resolveOrCancelFuture and the existing LeaseManagementConfig.dynamoDbRequestTimeout, passed from Scheduler through CoordinatorStateDAO and its delegates.
chenylee-aws
force-pushed
the
fix-leader-decider-hang
branch
from
October 30, 2026 01:41
cf5e956 to
96e1908
Compare
chenylee-aws
requested a deployment
to
manual-approval
October 30, 2026 01:41 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
chenylee-aws
marked this pull request as ready for review
October 30, 2026 18:16
lucienlu-aws
approved these changes
Oct 30, 2026
vincentvilo-aws
pushed a commit
to vincentvilo-aws/amazon-kinesis-client
that referenced
this pull request
Nov 3, 2026
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
DynamoDbAsyncToSyncClientAdapter, used by the leader-election lock client, waited on each DynamoDB call with an untimedjoin(). It now waits withFutureUtils.resolveOrCancelFutureandLeaseManagementConfig.dynamoDbRequestTimeout(), the same helper and timeout used for lease table calls. The timeout is passed fromSchedulerthroughCoordinatorStateDAOand its delegates.Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.