Skip to content

chore: add tests for install-receipts from sh - #776

Merged
Gankra merged 3 commits into
mainfrom
add-receipt-tests
Feb 8, 2024
Merged

Gankra merged 3 commits into
mainfrom
add-receipt-tests

Conversation

@Gankra

@Gankra Gankra commented Feb 6, 2024 •

Copy link
Copy Markdown
Contributor

fixes #773

@Gankra
Gankra force-pushed the add-receipt-tests branch 9 times, most recently from c624c72 to 240433d Compare February 6, 2024 06:24
@Gankra

Gankra commented Feb 6, 2024 •

Copy link
Copy Markdown
Contributor Author

TODO:

  • check if we really want ~/.cargo/ and not ~/.cargo/bin/ in the install receipt
  • pick a "good" seperator for the sed (currently stubbed to ~) ((or better escaping?))

@Gankra
Gankra force-pushed the add-receipt-tests branch from 240433d to 3946b24 Compare February 8, 2024 20:20
@Gankra
Gankra force-pushed the add-receipt-tests branch from 3946b24 to cf36b72 Compare February 8, 2024 21:34
@Gankra
Gankra merged commit e0d4cb1 into main Feb 8, 2024
@Gankra
Gankra deleted the add-receipt-tests branch February 8, 2024 22:06
@mistydemeo

Copy link
Copy Markdown
Contributor

check if we really want ~/.cargo/ and not ~/.cargo/bin/ in the install receipt

We do, yes. While we're likely to only install binaries, in the future we'll be installing other kinds of files - libraries, config files, etc. These are installed in other subdirectories inside the install prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sed error in install script

2 participants