Repository navigation
Add waiters for elasticache - #443
Merged
Merged
Conversation
Member
|
Thanks for adding these. The one thing I'd suggest changing is instead of using the 404 status code checker we use the error code returned by the service. There was a bug in botocore that prevented us from using this before, but this issue is now fixed. For example here's this change for RDS (https://github.com/boto/botocore/blob/develop/botocore/data/aws/rds/2014-10-31.waiters.json#L64-L68). |
Contributor
Author
|
I saw you released the fix for that, and so quickly too! Cheers! I've made the change you requested. |
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds 4 new waiters i've needed recently. I've used the same delays/attempts as RDS, which works for me quite well so far.