creating a new tool to compare interval lists - #3702
Merged
Conversation
jonn-smith
reviewed
Oct 17, 2017
| final GenomeLocParser genomeLocParser = new GenomeLocParser(samSequenceDictionary); | ||
| final GenomeLocSortedSet firstIntervals = getGenomeLocs(genomeLocParser, firstIntervalFile); | ||
| final GenomeLocSortedSet secondIntervals = getGenomeLocs(genomeLocParser, secondIntervalFile); | ||
| final String result = IntervalUtils.equateIntervals(firstIntervals.toList(), secondIntervals.toList()); |
Collaborator
There was a problem hiding this comment.
What happens if the interval files are both empty?
Collaborator
There was a problem hiding this comment.
Seems to be fine - added some tests to this effect and they behave as expected.
jonn-smith
requested changes
Oct 17, 2017
jonn-smith
left a comment
jonn-smith
left a comment
Collaborator
There was a problem hiding this comment.
Needs some comments, but looks reasonable. I had one quick question about the file comparison.
Codecov Report
@@ Coverage Diff @@
## master #3702 +/- ##
============================================
+ Coverage 87.08% 87.09% +<.01%
- Complexity 31522 31531 +9
============================================
Files 1930 1932 +2
Lines 145236 145271 +35
Branches 16096 16099 +3
============================================
+ Hits 126480 126519 +39
+ Misses 12903 12900 -3
+ Partials 5853 5852 -1
Continue to review full report at Codecov.
|
jonn-smith
force-pushed
the
lb_add_compare_intervals_tool
branch
from
January 11, 2019 20:57
99ede46 to
8f85021
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding a very simple tool to compare two interval list files