Repository navigation
feat(node): implement async hooks for nextTick TickObject tracking - #30578
Merged
Merged
Conversation
![gitstart-app[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
- Add functional emitInit, emitBefore, emitAfter, emitDestroy implementations - Implement async ID generation with executionAsyncIdStack tracking - Add TickObject async hooks integration in _next_tick.ts - Include Node.js-style stack corruption protection (try/catch + finally) - Update createHook to use internal AsyncHook implementation - Remove FIXME comments and deprecated helper functions Fixes test-stream-writable-samecb-singletick.js by enabling proper TickObject lifecycle tracking through async hooks.
bartlomieju
reviewed
Sep 1, 2025
bartlomieju
left a comment
bartlomieju
left a comment
Member
There was a problem hiding this comment.
This looks good, I want to do some more testing before landing, but the test appears to be passing now π
bartlomieju
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by GitStart to address the requirements from this ticket: DENB-29802.
Summary
Adds Async Hooks support for
process.nextTick()to enableTickObjectlifecycle tracking, unblocking the Node.js compatibility testtest-stream-writable-samecb-singletick.js.Changes
emitInit(),emitBefore(),emitAfter(),emitDestroy().nextAsyncId()andexecutionAsyncId()with an execution context stack._next_tick.ts.createHook()to use the internalAsyncHookimplementation.FIXMEcomments.Fixes
Testing
test-stream-writable-samecb-singletick.jspasses