Repository navigation
fix(ext/node): implement http.res.setHeaders - #30586
Merged
Merged
Conversation
Tango992
marked this pull request as draft
September 1, 2025 13:55
Tango992
force-pushed
the
fix-http-setheaders
branch
from
September 1, 2025 14:22
3570aee to
9ffbb46
Compare
Tango992
marked this pull request as ready for review
September 1, 2025 14:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30540
Also fixes res.writeHead implementation to parse array values correctly. For example,
res.writeHead(200, [["foo", "bar"]])andres.writeHead(200, ["foo", "bar"])should produce the same result.These changes allows parallel/test-http-response-setheaders.js to pass.