Skip to content

fix(cache): cache and uninstall are package manager subcommands - #30613

Merged
nathanwhit merged 1 commit into
denoland:mainfrom
nathanwhit:cache-managed
Sep 4, 2025
Merged

nathanwhit merged 1 commit into
denoland:mainfrom
nathanwhit:cache-managed

Conversation

@nathanwhit

Copy link
Copy Markdown
Member

No description provided.

@nathanwhit
nathanwhit requested a review from dsherret September 4, 2025 17:23
Comment thread cli/factory.rs
flags.subcommand,
DenoSubcommand::Install(_)
| DenoSubcommand::Uninstall(_)
| DenoSubcommand::Cache(_)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this depend on whether it's global or not?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah i guess so. I should probably change that for Install then too

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm not entirely sure. I'm just going to approve this PR :D

@dsherret dsherret left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants