Skip to content

fix(ext/node): rename conflict callback field typo - #32306

Merged
bartlomieju merged 1 commit into
denoland:mainfrom
Rohan5commit:fix/node-sqlite-conflict-typo
Feb 26, 2026
Merged

bartlomieju merged 1 commit into
denoland:mainfrom
Rohan5commit:fix/node-sqlite-conflict-typo

Conversation

@Rohan5commit

Copy link
Copy Markdown
Contributor

Summary

  • rename confict to conflict in the sqlite changeset handler context
  • update all references within apply_changeset

Why

  • removes a typo in callback state naming and improves readability/maintainability

Notes

  • no behavioral changes; this is an internal field rename only

@CLAassistant

CLAassistant commented Feb 24, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@bartlomieju
bartlomieju requested a review from Tango992 February 24, 2026 09:40
@Tango992

Copy link
Copy Markdown
Contributor

Would you please sign the CLA so we can get it merged? Thanks @Rohan5commit

@Rohan5commit
Rohan5commit force-pushed the fix/node-sqlite-conflict-typo branch from dbf2a35 to 4a30207 Compare February 25, 2026 02:19
@bartlomieju bartlomieju changed the title fix(node_sqlite): rename conflict callback field typo fix(ext/node): rename conflict callback field typo Feb 26, 2026
@bartlomieju
bartlomieju merged commit defb168 into denoland:main Feb 26, 2026
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants