Repository navigation
fix(node): report directory imports with node error code - #34076
Merged
Merged
Conversation
littledivy
approved these changes
May 15, 2026
littledivy
added a commit
to crowlKats/deno
that referenced
this pull request
Jun 10, 2026
…d#34076) Closes denoland/orchid#87 Maps local directory imports in the file fetcher to a Node-compatible TypeError with code ERR_UNSUPPORTED_DIR_IMPORT instead of surfacing raw IsADirectory/EISDIR OS errors. The graph loader now propagates that error through module loading. Tests: - cargo fmt --check - cargo check -p deno_cache_dir -p deno_resolver - cargo test -p deno_cache_dir test_file_fetcher_redirects -- --nocapture - ./x test-spec node/esm_dir_import/local_relative Note: ./x test-compat --list could not run in this checkout because the Node test suite directory is missing. --------- Co-authored-by: divybot <divybot@users.noreply.github.com> Co-authored-by: Divy Srivastava <me@littledivy.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes denoland/orchid#87
Maps local directory imports in the file fetcher to a Node-compatible TypeError with code ERR_UNSUPPORTED_DIR_IMPORT instead of surfacing raw IsADirectory/EISDIR OS errors. The graph loader now propagates that error through module loading.
Tests:
Note: ./x test-compat --list could not run in this checkout because the Node test suite directory is missing.