Repository navigation
fix(console): %c colors with same red component as previous color - #34784
Merged
Merged
Conversation
The previous comparison normalized any color string to an [r,g,b] array before comparing. An unparseable string like "inherit" or "foo" parses to null, which then compared equal to an absent (null) color, suppressing the reset escape (\x1b[49m / \x1b[39m) that cssToAnsi emits for those. Restrict the parse-and-compare-by-value path to the case both operands are strings, which is exactly the #21605 hex-prefix collision. Mixed cases (string vs null or array) keep the original colorEquals behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When formatting
console.log%cdirectives, the background-color andcolor of a span are compared against the previous span's to decide whether
a new ANSI escape needs to be emitted. That comparison used
colorEquals,which indexes its arguments as
[r, g, b]arrays, butbackground-colorand
colorare stored as raw strings (a named color, or a hex/rgb/hslstring). Comparing two hex strings by index instead compares their leading
characters, so any two colors sharing the same red component (e.g.
#FFFFFFand#FFAFC8, both starting#FF) were treated as equal and thenew color was never emitted, leaving the previous background to bleed into
the next span.
This normalizes both operands to
[r, g, b]arrays before comparing, socolors are compared by value regardless of how they were written.
Fixes #21605