Skip to content

fix(coverage): improve HTML report PageSpeed score - #34980

Merged
bartlomieju merged 2 commits into
denoland:mainfrom
manichandra:deno-29492-coverage-pagespeed
Jun 9, 2026
Merged

bartlomieju merged 2 commits into
denoland:mainfrom
manichandra:deno-29492-coverage-pagespeed

Conversation

@manichandra

Copy link
Copy Markdown
Contributor

Closes #29492

Improves the generated HTML coverage report's PageSpeed results by:

  • using a semantic <main> element
  • adding page metadata and an empty favicon
  • improving link visibility and text contrast
  • securing external links with rel="noopener noreferrer"
  • making theme preference handling resilient when local storage is unavailable
  • guarding theme controls against missing elements

Testing

  • ./x fmt
  • ./x lint
  • ./x build
  • cargo test -p integration_tests --test integration coverage::test_html_reporter

AI assistance was used to help investigate, implement, and validate this change.

@deno-cla-assistant

deno-cla-assistant Bot commented Jun 7, 2026 •

Copy link
Copy Markdown

Deno Individual Contributor License Agreement

All contributors have signed the CLA. Thank you!

Re-run CLA check


This is an automated message from CLA Assistant

@bartlomieju bartlomieju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the CLA

@manichandra

Copy link
Copy Markdown
Contributor Author

Please sign the CLA

I had signed on the same day i created the PR. triggered the CLA check just now and looks like passed

@bartlomieju bartlomieju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bartlomieju
bartlomieju enabled auto-merge (squash) June 9, 2026 17:27
@bartlomieju
bartlomieju merged commit 9949f15 into denoland:main Jun 9, 2026
136 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

suggestion: 100% PageSpeed score for coverage explorer

2 participants