Repository navigation
fix(ext/http): join split request headers consistently - #35081
Merged
nathanwhit merged 1 commit intoJun 10, 2026
Merged
Conversation
nathanwhit
marked this pull request as ready for review
June 9, 2026 23:37
nathanwhit
enabled auto-merge (squash)
June 9, 2026 23:38
nathanwhit
disabled auto-merge
June 9, 2026 23:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browsers can send split
Cookiefields over HTTP/2. Deno already joined cookies with"; "for bulk request-header exposure and the raw backend, but the hyper-backed single-header getter used the generic", "separator. That madereq.headers.get("cookie")disagree with iteration and broke cookie parsing for frameworks that read cookies throughget().This change centralizes request-header value separator selection, applies it to the hyper single-header getter, and keeps the raw and bulk paths on the same rule. It also adds raw HTTP/1 and raw HTTP/2 tests that send physically split
Cookieand genericX-Testfields, then assert bothheaders.get()and header iteration produce consistent combined values.Validation: