Repository navigation
fix(ext/node): make registerHooks resolve hook work for nested imports - #35169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
module.registerHooksresolve hook that rewrites specifiers (for exampleappending a fragment for HMR-style cache busting) failed on nested imports
with "Loading unprepared module". The module graph is prepared using
deno_graph's own resolution, which doesn't invoke JS resolve hooks, so a
hook-rewritten URL for a nested import was never present in the graph when
deno_core later requested it.
When a resolve hook is active and the requested specifier is missing from
the graph, the loader now prepares it on demand before loading, the same
best-effort preparation already used for load hook redirects.
Fixes #35163