Repository navigation
feat(desktop): enable --hmr for React Router - #35900
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deno desktop --hmralready supports running a detected framework dev server and using itsLocal:URL for desktop HMR.React Router framework projects were detected correctly, but both the SPA and SSR branches left
hmr_commandunset. As a result,deno desktop --hmr .did not start the React Router dev server and could not use React Router's Vite-powered HMR flow.Change
Wire React Router's
hmr_commandtodeno task devfor:ssr: false)This matches the existing Vite-based framework HMR path.
Tests
hmr_commandisdeno task devhmr_commandisdeno task devcargo test -p deno --lib react_router