Repository navigation
fix(webtransport): avoid url parse panic - #36066
Merged
bartlomieju merged 1 commit intoJul 16, 2026
Merged
Conversation
nathanwhit
marked this pull request as ready for review
July 15, 2026 20:47
bartlomieju
approved these changes
Jul 16, 2026
bartlomieju
pushed a commit
that referenced
this pull request
Jul 23, 2026
- serialize parsed WebTransport URLs with the captured URL prototype method - return a typed error if the native URL conversion receives an invalid value - add a regression covering an overridden `URL.prototype.toString`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URL.prototype.toStringBug
The WebTransport constructor parses its URL up front, but the connection path later serialized that object through mutable prototype dispatch. An override could replace the serialized value with an invalid string, while the native connection op assumed parsing was infallible and unwrapped the result. Using the captured method preserves the parsed URL, and the native boundary now handles conversion failure without a process panic.
Validation
./tools/format.jscargo fmt --check --package deno_netcargo check -p deno_netcargo build --bin denocargo test -p specs_tests --test specs run::webtransport -- --nocapture