Repository navigation
fix(core): enforce JSON requests in FsModuleLoader - #36137
Merged
nathanwhit merged 2 commits intoJul 20, 2026
Merged
Conversation
bartlomieju
pushed a commit
that referenced
this pull request
Jul 23, 2026
## Summary - reject non-JSON files when `FsModuleLoader` receives a JSON module request - return a `TypeError` with the actual module type and specifier - cover JavaScript, extensionless, and valid JSON files ## Details `FsModuleLoader` already rejected JSON files loaded without the JSON import attribute, but it did not enforce the reverse mismatch. A `.js` or extensionless file requested as JSON could therefore be returned as a JavaScript module. The loader now validates the requested and selected module types before reading the source. ## Validation - `./tools/format.js` - `cargo check -p deno_core` - `cargo test -p deno_core fs_module_loader -- --nocapture`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FsModuleLoaderreceives a JSON module requestTypeErrorwith the actual module type and specifierDetails
FsModuleLoaderalready rejected JSON files loaded without the JSON import attribute, but it did not enforce the reverse mismatch. A.jsor extensionless file requested as JSON could therefore be returned as a JavaScript module.The loader now validates the requested and selected module types before reading the source.
Validation
./tools/format.jscargo check -p deno_corecargo test -p deno_core fs_module_loader -- --nocapture