Repository navigation
fix(desktop): retain update signature verification op - #36152
Merged
Merged
Conversation
Signed-off-by: kunjrathod2005 <rathodkunj2005@gmail.com>
littledivy
approved these changes
Jul 26, 2026
littledivy
enabled auto-merge (squash)
July 26, 2026 06:16
auto-merge was automatically disabled
August 4, 2026 03:46
Head branch was pushed to by a user without write access
Contributor
Author
|
Pushed a small follow-up for the CI failure: Verification:
|
bartlomieju
pushed a commit
that referenced
this pull request
Aug 6, 2026
## Summary - retain `op_desktop_verify_ed25519` when imported ops are removed during runtime bootstrap - assert that the desktop update signature-verification op remains exposed Without this entry, the desktop auto-update initializer receives `undefined` for the verification op and cannot stage signed updates. Closes #36150 ## Verification - `./tools/format.js --check runtime/js/99_main.js tests/unit/ops_test.ts` - `./tools/lint.js --js runtime/js/99_main.js tests/unit/ops_test.ts` --------- Signed-off-by: kunjrathod2005 <rathodkunj2005@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
op_desktop_verify_ed25519when imported ops are removed during runtime bootstrapWithout this entry, the desktop auto-update initializer receives
undefinedfor the verification op and cannot stage signed updates.Closes #36150
Verification
./tools/format.js --check runtime/js/99_main.js tests/unit/ops_test.ts./tools/lint.js --js runtime/js/99_main.js tests/unit/ops_test.ts