Repository navigation
fix(cli): accept all valid sys permission descriptors - #36753
Merged
bartlomieju merged 1 commit intoSep 8, 2026
Merged
Conversation
Deno Individual Contributor License AgreementAll contributors have signed the CLA. Thank you! This is an automated message from CLA Assistant |
hugojosefson
marked this pull request as ready for review
September 1, 2026 10:25
hugojosefson
force-pushed
the
fix/allow-sys-inspector-cli-parser
branch
3 times, most recently
from
September 3, 2026 07:06
ef66a27 to
ae3ae0d
Compare
hugojosefson
force-pushed
the
fix/allow-sys-inspector-cli-parser
branch
from
September 3, 2026 15:52
ae3ae0d to
5ec7877
Compare
bartlomieju
enabled auto-merge (squash)
September 8, 2026 08:31
petamoriken
added a commit
to petamoriken/deno
that referenced
this pull request
Sep 8, 2026
Resolve conflict in libs/cli_parser/src/convert.rs: upstream (denoland#36753) replaced the hardcoded VALID_SYS_DESCRIPTORS list with SysDescriptor::parse, which already accepts the "localFonts" descriptor added on this branch, so the local list is no longer needed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
bartlomieju
pushed a commit
that referenced
this pull request
Sep 16, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression
Deno 2.9.6 has a regression (compared to 2.9.5) where it stops accepting valid granular sys permissions during CLI parsing. For example:
The
deno_cli_parsercutover introduced a second sys-descriptor allowlist that had drifted fromdeno_permissions::SysDescriptor::parse. It omittedinspectorand other valid descriptors such assetuidandumask.Fix
This PR removes the duplicate list and validates both
--allow-sysand--deny-sysvalues with the runtime parser. Validation does not replace the original flag value, so aliases such asusernameretain their existing CLI representation.Parser tests cover accepted descriptors, rejected descriptors, and alias preservation for both flags.
Related: #36519, which covers
node:inspectorsys-permission behavior and needs--allow-sys=inspector.Testing done
AI usage
I used OpenAI GPT-5.6 models via OpenCode for all of this.