Skip to content

[v0.13] allow network.host daemon entitlement by default in container driversΒ #2255

Closed

Description

@tonistiigi

Description

Based on comments in moby/buildkit#4524 (comment) , there shouldn't be a need to set --allowed-entitlemtns network.host as buildkitd flags when builder runs in a container as the container network is already isolated. At least when --driver-opt network does not equal host.

Activity

  1. added this to the v0.13.0 milestone on Feb 12, 2024
  2. crazy-max commented on Feb 13, 2024

    @crazy-max
    Member

    I think it would also makes sense for kubernetes driver (cc @AkihiroSuda)

  3. crazy-max commented on Feb 13, 2024

    @crazy-max
    Member

    I was wondering one thing. Should we set this entitlement silently when creating the builder or set it in buildx store? I think silently makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions