Skip to content

kubernetes driver: add serviceaccount opt - #1597

Merged
jedevc merged 2 commits into
docker:masterfrom
robertlestak:k8s-sa
May 2, 2023
Merged

jedevc merged 2 commits into
docker:masterfrom
robertlestak:k8s-sa

Conversation

@robertlestak

@robertlestak robertlestak commented Feb 4, 2023 •

Copy link
Copy Markdown

Addresses #766

Adds a new (optional) serviceaccount opt. When provided, it will be set as the created pod's serviceAccountName.

Example usage:

docker buildx create --name example \
    --driver kubernetes \
    --driver-opt=serviceaccount=example-sa

@robertlestak
robertlestak force-pushed the k8s-sa branch 2 times, most recently from 84e4287 to bce3c4e Compare February 4, 2023 03:08
@robertlestak robertlestak changed the title kubernetes driver: add serviceAccount opt kubernetes driver: add serviceaccount opt Feb 4, 2023
@crazy-max

Copy link
Copy Markdown
Member

PTAL @morlay @AkihiroSuda

@crazy-max crazy-max left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dvdksn

dvdksn commented Apr 14, 2023 •

Copy link
Copy Markdown
Contributor

side note @crazy-max, I think the section in the file you linked to is actually redundant, now that we have the full opt descriptions for each driver in the docs. If you agree, I can create a PR to clean up buildx_create.md

@crazy-max

Copy link
Copy Markdown
Member

side note @crazy-max, I think the section in the file you linked to is actually redundant, now that we have the full opt descriptions for each driver in the docs. If you agree, I can create a PR to clean up buildx_create.md

Ah sure yeah sounds good

robertlestak and others added 2 commits April 26, 2023 16:40
Signed-off-by: robertlestak <robert.lestak@umusic.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc

jedevc commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

@crazy-max @dvdksn for the time being, I pushed a commit to update buildx_create.md - we can clean it up later.

Anything else blocking on merging this, so we can get it in v0.11?

@jedevc
jedevc requested a review from crazy-max April 26, 2023 15:45
@jedevc jedevc linked an issue Apr 26, 2023 that may be closed by this pull request
@jedevc
jedevc dismissed crazy-max’s stale review May 2, 2023 11:55

Updated the docs

@jedevc
jedevc merged commit 43a07f3 into docker:master May 2, 2023
@robertlestak
robertlestak deleted the k8s-sa branch May 9, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting Service Account on Kubernetes Deployment

5 participants