Skip to content

driver: add status reporting and a timeout to the remote driver bootstrap - #2130

Merged
tonistiigi merged 1 commit into
docker:masterfrom
jsternberg:remote-bootstrap-timeout
Nov 17, 2023
Merged

tonistiigi merged 1 commit into
docker:masterfrom
jsternberg:remote-bootstrap-timeout

Conversation

@jsternberg

Copy link
Copy Markdown
Collaborator

This adds status reporting for the remote driver so it shows the length
of time it is spending waiting for the connection. If the service is
already present, this logger isn't shown but it should help provide a
message to show the user why the build is stalled.

A timeout of 20 seconds has been added to the bootstrap.

Fixes #2120.

…trap

This adds status reporting for the remote driver so it shows the length
of time it is spending waiting for the connection. If the service is
already present, this logger isn't shown but it should help provide a
message to show the user why the build is stalled.

A timeout of 20 seconds has been added to the bootstrap.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
@jsternberg

Copy link
Copy Markdown
Collaborator Author

Some sample outputs:

[+] Building 20.0s (1/1) FINISHED
 => ERROR [internal] waiting for connection                                                                                 20.0s
------
 > [internal] waiting for connection:
------
ERROR: context deadline exceeded

For ctrl+c:

[+] Building 0.9s (1/1) FINISHED
 => CANCELED [internal] waiting for connection                                                                               0.9s
ERROR: context canceled

@tonistiigi
tonistiigi requested a review from nicks November 17, 2023 21:45

@nicks nicks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tonistiigi
tonistiigi merged commit 0962fdb into docker:master Nov 17, 2023
@jsternberg
jsternberg deleted the remote-bootstrap-timeout branch November 17, 2023 23:00
@crazy-max crazy-max added this to the v0.13.0 milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature request: buildx should timeout if node never becomes healthy

4 participants