Repository navigation
Work around geometry shader topology mismatch - #4716
Merged
Merged
Conversation
doitsujin
marked this pull request as draft
February 26, 2025 16:39
doitsujin
marked this pull request as ready for review
February 26, 2025 19:53
doitsujin
force-pushed
the
gs-topology-workaround
branch
from
February 26, 2025 19:53
91ac0d2 to
4cff85f
Compare
10 of 19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #4714 for now since both touch shader stuff.
Works around an issue in Clanfolk where the game would use a GS with
pointinput topology when the pipeline uses triangles.DCS World also hits this issue with its particle system, except there it's even more cursed and its GS uses
pointwhile tessellation outputs lines.Needs some testing, especially in games that are known to do cursed Nvidia things (think Hairworks) since they really seem to love their geometry shaders.
See https://gitlab.freedesktop.org/mesa/mesa/-/issues/11853, https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33533