Repository navigation
Revert "[d3d9] Ignore buffer lock range for static D3DPOOL_DEFAULT buffers - #5764
Merged
Merged
Conversation
…ffers" This reverts commit 3972f88. Kane and Lynch performance is horrible with this change and we only did it for some irrelevant demo.
Contributor
|
For posterity's sake: it doesn't affect only Kane & Lynch, but also the new King's Bounty games, starting with King's Bounty: The Legend and all later standalone addons. The PR will also fix the performance regression in those games, since @Blisto91 bisected it down to the same commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change to ignore the locking range arguments for
D3DPOOL_DEFAULTbuffers was done to fix #5067 because IIRC that wrote outside of the provided range. It severely impacted performance in Kane and Lynch.A random broken demo is much less important as an actual game so let's just revert it for now.
Fixes #5638