Skip to content

Fix null forgiving F1 keyword - #20341

Merged
IEvangelist merged 1 commit into
dotnet:masterfrom
Youssef1313:patch-17
Sep 8, 2020
Merged

IEvangelist merged 1 commit into
dotnet:masterfrom
Youssef1313:patch-17

Conversation

@Youssef1313

@Youssef1313 Youssef1313 commented Aug 28, 2020 •

Copy link
Copy Markdown
Member

@Youssef1313

Copy link
Copy Markdown
Member Author

@BillWagner Once dotnet/roslyn#47516 is reviewed for correctness, this should be ready to merge, then Roslyn's PR.

@davidwengier davidwengier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is any reason to wait for the Roslyn PR to be approved, having the same f1_keyword in two pages is a problem regardless of whether any code currently points to it.

@davidwengier davidwengier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is any reason to wait for the Roslyn PR to be approved, having the same f1_keyword in two pages is a problem regardless of whether any code currently points to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with !_CSharpKeyword

5 participants