Skip to content

Fix source indexer stage - #7694

Merged
adamsitnik merged 14 commits into
dotnet:mainfrom
jjonescz:complog
Sep 8, 2026
Merged

adamsitnik merged 14 commits into
dotnet:mainfrom
jjonescz:complog

Conversation

@jjonescz

@jjonescz jjonescz commented Aug 11, 2026 •

Copy link
Copy Markdown
Member

Validation: https://dev.azure.com/dnceng/internal/_build/results?buildId=3044826&view=results

(Ignore the intermediate commits, they contain some experiments; this should be squashed on merge.)

Microsoft Reviewers: Open in CodeFlow

@jjonescz
jjonescz marked this pull request as ready for review August 11, 2026 15:19
@jjonescz
jjonescz requested a review from a team as a code owner August 11, 2026 15:19
Copilot AI lite review requested due to automatic review settings August 11, 2026 15:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the Azure Pipelines configuration to fix/unstick the source indexing stage by reusing the repository’s restore/build steps in a shared template and wiring those steps into the source-index job.

Changes:

  • Introduces a reusable RestoreAndBuild.yml pipeline template encapsulating Node setup, restore, solution generation, and build.
  • Refactors BuildAndTest.yml to consume the new restore/build template instead of duplicating those steps.
  • Updates azure-pipelines.yml to drive source indexing via a parameterized condition and to run restore/build as preSteps for the source-index job.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
eng/pipelines/templates/RestoreAndBuild.yml New shared restore/build step template used by build/test and source-index preSteps.
eng/pipelines/templates/BuildAndTest.yml Switches restore/build steps to use the shared template.
azure-pipelines.yml Updates source index configuration (condition, build script variable, and preSteps using the shared template).

πŸ’‘ Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread azure-pipelines.yml Resolved
Comment thread azure-pipelines.yml Resolved
Comment thread azure-pipelines.yml Resolved
@jjonescz

Copy link
Copy Markdown
Member Author

@dotnet/dotnet-extensions-infra PTAL; this fixes official builds of this repo which have been broken for some time

@adamsitnik adamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes official builds of this repo which have been broken for some time

Since I am about to perform a release (attempt), I am going to merge this PR. Thank you for fixing the build @jjonescz !

@adamsitnik
adamsitnik merged commit 0fe52df into dotnet:main Sep 8, 2026
7 checks passed
@jjonescz
jjonescz deleted the complog branch September 9, 2026 08:58
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants