Repository navigation
Fail Azure DevOps plugin builds on npm errors - #7778
Conversation
Co-authored-by: jozkee <16040868+jozkee@users.noreply.github.com>
Co-authored-by: jozkee <16040868+jozkee@users.noreply.github.com>
|
@copilot can you resolve the CI errors |
The Windows failure is the expected now-unmasked |
There was a problem hiding this comment.
Copilot review overview
๐ก Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates the Azure DevOps extension build to fail on native command errors and avoid stale build artifacts.
Changes:
- Added exit-code validation for all
npm/npxcommands. - Added cleanup of generated directories before building.
- Added regression coverage and pipeline execution before packaging.
| File | Description |
|---|---|
| src/โLibraries/โMicrosoft.Extensions.AI.Evaluation.Reporting/โTypeScript/โazure-devops-report/โbuild.Tests.ps1 | Updated as part of this pull request. |
| src/โLibraries/โMicrosoft.Extensions.AI.Evaluation.Reporting/โTypeScript/โazure-devops-report/โbuild.ps1 | Updated as part of this pull request. |
| eng/โpipelines/โtemplates/โBuildAndTest.yml | Updated as part of this pull request. |
๐ก Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Keep the fix focused on propagating native command failures without introducing a standalone PowerShell test into every Windows CI run. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
๐ก Changes recommended
The regression test and pipeline integration promised by the PR are missing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (1)
๐ Good job! The coverage increased ๐
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1614742&view=codecoverage-tab |


The Azure DevOps extension build could ignore failed
npm/npxcommands and package stale dependencies, producing nondeterministic false-green builds.Fail-fast command execution
npmandnpxinvocation through an exit-code-checking helper.Deterministic workspace
node_modulesanddistdirectories before installation.Evidence
Build Azure DevOps pluginstep loggednpm error code E401, demonstrating the false-green behavior this PR fixes.Validation
npm ci --omit=devE401 failure.