Repository navigation
AI: Remove obsolete OpenAI JsonPatch workaround - #7815
Merged
Merged
Conversation
OpenAI 2.14.0 includes the upstream bounds-check fix, so direct JsonPatch lookups now safely handle empty choices and null deltas. Removing the manual JSON traversal fixes Azure asynchronous content-filter chunks that contain no delta. Fixes #7790. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The null-delta regression needs checked-in automated coverage.
1 open finding
What changed in this PR
Removes the obsolete OpenAI JsonPatch workaround while safely handling empty choices and null-delta Azure chunks.
Changes:
- Restores direct reasoning-content patch lookups.
- Removes manual JSON traversal.
| File | Description |
|---|---|
OpenAIChatClient.cs |
Simplifies reasoning-content extraction using fixed OpenAI 2.14.0 APIs. |
🧠 Review effort: Balanced
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1627071&view=codecoverage-tab |
Verify Azure annotation-only streaming chunks do not interrupt enumeration and that trailing usage remains available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1628570&view=codecoverage-tab |
valkiara
reviewed
Oct 9, 2026
valkiara
left a comment
valkiara
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 4047f52. OpenAI 2.14.0 is already pinned in eng/packages/General.props, so the direct lookups use the SDK version with the upstream fix.
Ran the adapter test project on net10.0: 391 passed, 163 skipped with live integration tests disabled. I also ran five local cases with an annotation before text: empty choices, a missing delta, an explicit null delta, an empty delta, and null reasoning_content. All completed with text, the stop reason, and trailing usage preserved. The existing streaming and non-streaming reasoning tests passed too.
No issues found in the changed paths.
jeffhandley
approved these changes
Oct 12, 2026
evgenyfedorov2
pushed a commit
to evgenyfedorov2/dotnet-extensions
that referenced
this pull request
Oct 15, 2026
* Remove obsolete OpenAI JsonPatch workaround OpenAI 2.14.0 includes the upstream bounds-check fix, so direct JsonPatch lookups now safely handle empty choices and null deltas. Removing the manual JSON traversal fixes Azure asynchronous content-filter chunks that contain no delta. Fixes dotnet#7790. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add regression test for null-delta filter chunks Verify Azure annotation-only streaming chunks do not interrupt enumeration and that trailing usage remains available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 12d337a) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7f884d96-e2eb-429c-8e19-827062cdb05c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI 2.14.0 includes the upstream bounds-check fix for openai/openai-dotnet#1281, so this removes the now-obsolete manual reasoning-content JSON traversal and restores direct
JsonPatchlookups; relying on the corrected SDK traversal fixes the scenario reported in #7790, where Azure asynchronous content-filter chunks contain a choice with no delta, and supersedes the guard-based approach proposed in #7792. A focused SSE regression test now covers text, stop, the annotation-only null-delta chunk, and trailing usage. Fixes #7790.