Repository navigation
Update HeaderParsing README with current metric and tag names - #7838
Merged
evgenyfedorov2 merged 1 commit intoOct 15, 2026
Conversation
The metric and tag names were changed in dotnet#4482, but the README's Metrics table still listed the old ones. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation now accurately matches the library’s metric declarations.
0 open findings
What changed in this PR
Updates HeaderParsing metric documentation to match the names emitted by Metric.cs.
Changes:
- Replaces legacy metric names.
- Updates associated dimension/tag names.
| File | Description |
|---|---|
src/Libraries/Microsoft.AspNetCore.HeaderParsing/README.md |
Documents current HeaderParsing metric and tag names. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
evgenyfedorov2
enabled auto-merge (squash)
October 14, 2026 09:55
Collaborator
🎉 Good job! The coverage increased 🎉
Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1634796&view=codecoverage-tab |
dariusclay
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Metrics table in the
Microsoft.AspNetCore.HeaderParsingREADME still lists the metric and tag names from before they were renamed in #4482. This updates the table to the names the library emits today (seeMetric.cs):HeaderParsing.ParsingErrorsaspnetcore.header_parsing.parse_errorsHeaderParsing.CacheAccessaspnetcore.header_parsing.cache_accessesHeaderNameaspnetcore.header_parsing.header.nameKinderror.typeTypeaspnetcore.header_parsing.cache_access.typeOnly the names change. The table's structure and wording stay the same. Docs-only.
Microsoft Reviewers: Open in CodeFlow